Hi Sam,
On Thu, Oct 14, 2021 at 09:35:20PM +0200, Sam Ravnborg wrote:
> Hi Guido,
>
> > > >
> > > > + if (ret != -EPROBE_DEFER) {
> > > > #ifdef CONFIG_OF
> > > > - DRM_ERROR("failed to attach bridge %pOF to encoder %s: %d\n",
> > > > - bridge->of_node, encoder->name, ret);
> > > > + DRM_ERROR("failed to attach bridge %pOF to encoder %s: %d\n",
> > > > + bridge->of_node, encoder->name, ret);
> > >
> > > It would be better to use drm_probe_err().
> >
> > That's what i thought initially but since the rest here uses DRM_*
> > logging i stuck with it. Happy to change that though.
>
> If we continue to use the deprecated DRM_ logging functions then we will
> never get rid of them. And then I like the simplicity of
> drm_probe_err().
I wasn't aware those are deprecated. I'll fix that up in case this patch
is needed, which
https://lore.kernel.org/dri-devel/CAMty3ZAsn4K0WFRC_FNN2Mina0gSu4Nc1y1zVsoZ8GuSqcQFsA@xxxxxxxxxxxxxx/
makes it a bit look like it.
Cheers,
-- Guido
>
> In the end it is up to you.
>
> Sam
>
