On Mon, 11 Oct 2021, Matthew Brost <matthew.brost@xxxxxxxxx> wrote: > On Mon, Oct 11, 2021 at 08:51:03PM +0530, Thanneeru Srinivasulu wrote: >> Replace DRM_ERROR with CT_PROBE_ERROR to report early CTB failures. >> >> Signed-off-by: Thanneeru Srinivasulu <thanneeru.srinivasulu@xxxxxxxxx> > > Reviewed-by: Matthew Brost <matthew.brost@xxxxxxxxx> > >> --- >> drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c >> index 0a3504bc0b61..83764db0fd6d 100644 >> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c >> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c >> @@ -191,8 +191,8 @@ static int ct_register_buffer(struct intel_guc_ct *ct, u32 type, >> err = guc_action_register_ct_buffer(ct_to_guc(ct), type, >> desc_addr, buff_addr, size); >> if (unlikely(err)) >> - CT_ERROR(ct, "Failed to register %s buffer (%pe)\n", >> - guc_ct_buffer_type_to_str(type), ERR_PTR(err)); >> + CT_PROBE_ERROR(ct, "Failed to register %s buffer (%pe)\n", >> + guc_ct_buffer_type_to_str(type), ERR_PTR(err)); Please tell me why we are adding not just i915-specific logging helpers, but file specific ones? To be honest I'd like to see all of the CT_ERROR, CT_DEBUG, CT_PROBE_ERROR macros just gone. BR, Jani. >> return err; >> } >> >> -- >> 2.25.1 >> -- Jani Nikula, Intel Open Source Graphics Center
