Hello, On Mon, Oct 11, 2021 at 03:27:41PM +0200, Uwe Kleine-König wrote: > this series is part of my new quest to make spi remove callbacks return > void. Today they return an int, but the only result of returning a > non-zero value is a warning message. So it's a bad idea to return an > error code in the expectation that not freeing some resources is ok > then. The same holds true for i2c and platform devices which benefit en > passant for a few drivers. > > The patches in this series address some of the spi drivers that might > return non-zero and adapt them accordingly to return zero instead. For > most drivers it's just about not hiding the fact that they already > return zero. > > Given that there are quite some more patches of this type to create > before I can change the spi remove callback, I suggest the respecive > subsystem maintainers pick up these patches. There are no > interdependencies in this series. > > Uwe Kleine-König (13): > drm/panel: s6e63m0: Make s6e63m0_remove() return void > hwmon: adt7x10: Make adt7x10_remove() return void > hwmon: max31722: Warn about failure to put device in stand-by in > .remove() > input: adxl34xx: Make adxl34x_remove() return void > input: touchscreen: tsc200x: Make tsc200x_remove() return void > media: cxd2880: Eliminate dead code > mfd: mc13xxx: Make mc13xxx_common_exit() return void > mfd: stmpe: Make stmpe_remove() return void > mfd: tps65912: Make tps65912_device_exit() return void > serial: max310x: Make max310x_remove() return void > serial: sc16is7xx: Make sc16is7xx_remove() return void > staging: fbtft: Make fbtft_remove_common() return void > tpm: st33zp24: Make st33zp24_remove() return void I thought I would be a good enough programmer to not need build tests. Obviously I was wrong and introduced build problems with the following patches: input: touchscreen: tsc200x: Make tsc200x_remove() return void mfd: mc13xxx: Make mc13xxx_common_exit() return void serial: max310x: Make max310x_remove() return void serial: sc16is7xx: Make sc16is7xx_remove() return void Please don't apply these (unless you also fix the trivial problems in them). I will prepare a v2 soon. Best regards and sorry for the inconvenience, Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
Attachment:
signature.asc
Description: PGP signature
