Re: [PATCH v4 1/7] dt-bindings: mediatek,dpintf: Add DP_INTF binding

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Oct 11, 2021 at 8:43 AM Markus Schneider-Pargmann
<msp@xxxxxxxxxxxx> wrote:
>
> Hi,
>
> On Mon, Oct 11, 2021 at 08:36:18AM -0500, Rob Herring wrote:
> > On Mon, 11 Oct 2021 11:46:18 +0200, Markus Schneider-Pargmann wrote:
> > > DP_INTF is a similar functional block to mediatek,dpi but is different
> > > in that it serves the DisplayPort controller on mediatek SoCs and uses
> > > different clocks. Therefore this patch creates a new binding file for
> > > this functional block.
> > >
> > > Signed-off-by: Markus Schneider-Pargmann <msp@xxxxxxxxxxxx>
> > > ---
> > >
> > > Notes:
> > >     Changes v3 -> v4:
> > >     - Fixed clock names in the example as the clock patch series is merged into
> > >       next now
> > >     - Add missing ports decleration to the example
> > >
> > >     Changes v1 -> v2:
> > >     - Move the devicetree binding from mediatek,dpi into its own binding file.
> > >
> > >  .../display/mediatek/mediatek,dpintf.yaml     | 86 +++++++++++++++++++
> > >  1 file changed, 86 insertions(+)
> > >  create mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,dpintf.yaml
> > >
> >
> > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> > on your patch (DT_CHECKER_FLAGS is new in v5.13):
> >
> > yamllint warnings/errors:
> >
> > dtschema/dtc warnings/errors:
> > Documentation/devicetree/bindings/display/mediatek/mediatek,dpintf.example.dts:21:18: fatal error: dt-bindings/clock/mt8195-clk.h: No such file or directory
> >    21 |         #include <dt-bindings/clock/mt8195-clk.h>
> >       |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> The mt8195 clock series was already merged and is available in
> linux-next. I checked with make dt_binding_check before sending.

The bot has no way of knowing that, and the dependency is not called
out in this patch for me to know that when reviewing the failures.

Rob



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux