Hi Dmityry, On Sun, Sep 26, 2021 at 03:10:05AM +0300, Dmitry Baryshkov wrote: > Add driver to support Sharp LS06T1SX01 FullHD panel. The panel uses > nt35695 driver IC. For example this LCD module can be found in the > kwaek.ca Dragonboard Display Adapter Bundle. > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> The driver looks fine. It would have been nicer could you have used regulator_bulk - but I guess timing constraints prevents that - right? Please address the following checkpatch warnings: -:181: WARNING:MSLEEP: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst #181: FILE: drivers/gpu/drm/panel/panel-sharp-ls060t1sx01.c:129: + msleep(1); -:187: WARNING:MSLEEP: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst #187: FILE: drivers/gpu/drm/panel/panel-sharp-ls060t1sx01.c:135: + msleep(10); -:193: WARNING:MSLEEP: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst #193: FILE: drivers/gpu/drm/panel/panel-sharp-ls060t1sx01.c:141: + msleep(10); -:210: WARNING:MSLEEP: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst #210: FILE: drivers/gpu/drm/panel/panel-sharp-ls060t1sx01.c:158: + msleep(10); -:241: WARNING:MSLEEP: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst #241: FILE: drivers/gpu/drm/panel/panel-sharp-ls060t1sx01.c:189: + msleep(10); I expect patches to be checkpatch --strict clean - or it is mentioned in the changelog otherwise. Sam
