Re: [PATCH v6 3/8] drm/i915/gtt: drop unneeded make_unshrinkable

[Thomas Hellström <thomas.hellstrom@xxxxxxxxxxxxxxx>]

On 10/5/21 20:24, Matthew Auld wrote:
> We already do this when mapping the pages.
>
> Signed-off-by: Matthew Auld <matthew.auld@xxxxxxxxx>
> Cc: Thomas Hellström <thomas.hellstrom@xxxxxxxxxxxxxxx>
> ---
>   drivers/gpu/drm/i915/gt/gen6_ppgtt.c | 1 -
>   drivers/gpu/drm/i915/gt/gen8_ppgtt.c | 1 -
>   2 files changed, 2 deletions(-)

Reviewed-by: Thomas Hellström <thomas.hellstrom@xxxxxxxxxxxxxxx>



> diff --git a/drivers/gpu/drm/i915/gt/gen6_ppgtt.c b/drivers/gpu/drm/i915/gt/gen6_ppgtt.c
> index 890191f286e3..baea9770200a 100644
> --- a/drivers/gpu/drm/i915/gt/gen6_ppgtt.c
> +++ b/drivers/gpu/drm/i915/gt/gen6_ppgtt.c
> @@ -185,7 +185,6 @@ static void gen6_alloc_va_range(struct i915_address_space *vm,
>   
>   			pt = stash->pt[0];
>   			__i915_gem_object_pin_pages(pt->base);
> -			i915_gem_object_make_unshrinkable(pt->base);
>   
>   			fill32_px(pt, vm->scratch[0]->encode);
>   
> diff --git a/drivers/gpu/drm/i915/gt/gen8_ppgtt.c b/drivers/gpu/drm/i915/gt/gen8_ppgtt.c
> index 037a9a6e4889..8af2f709571c 100644
> --- a/drivers/gpu/drm/i915/gt/gen8_ppgtt.c
> +++ b/drivers/gpu/drm/i915/gt/gen8_ppgtt.c
> @@ -301,7 +301,6 @@ static void __gen8_ppgtt_alloc(struct i915_address_space * const vm,
>   
>   			pt = stash->pt[!!lvl];
>   			__i915_gem_object_pin_pages(pt->base);
> -			i915_gem_object_make_unshrinkable(pt->base);
>   
>   			fill_px(pt, vm->scratch[lvl]->encode);
>