Hi Doug, On Fri, Oct 01, 2021 at 11:02:54AM -0700, Doug Anderson wrote: > On Thu, Sep 23, 2021 at 7:26 PM Laurent Pinchart wrote: > > > > > > > err_conn_init: > > > > > drm_dp_aux_unregister(&pdata->aux); > > > > > return ret; > > > > > @@ -792,9 +790,30 @@ static void ti_sn_bridge_set_dsi_rate(struct ti_sn65dsi86 *pdata) > > > > > regmap_write(pdata->regmap, SN_DSIA_CLK_FREQ_REG, val); > > > > > } > > > > > > > > > > +/* > > > > > + * Find the connector and fish out the bpc from display_info. It would > > > > > + * be nice if we could get this instead from drm_bridge_state, but that > > > > > + * doesn't yet appear to be the case. > > > > > > > > You already have a bus format in the bridge state, from which you can > > > > derive the bpp. Could you give it a try ? > > > > > > Possibly the bridge should be converted to ->atomic_enable(), etc.. > > > I'll leave that for another time > > > > It should be fairly straightforward, and would avoid the hack below. > > Given this point of controversy, my inclination is to wait and not > apply this patch now. I don't think there's anything urgent here, > right? Worst case eventually Laurent might pick it up in his patch > series? At least we know it will work with the MSM driver once patch > #1 lands. :-) I've recorded the task for my upcoming work on the ti-sn65dsi86 driver. -- Regards, Laurent Pinchart
