Hi, On Mon, Sep 27, 2021 at 06:44:21PM +0200, H. Nikolaus Schaller wrote: > From: Sam Ravnborg <sam@xxxxxxxxxxxx> > > Add DT bindings for the hdmi driver for the Ingenic JZ4780 SoC. > Based on .txt binding from Zubair Lutfullah Kakakhel > > Signed-off-by: Sam Ravnborg <sam@xxxxxxxxxxxx> > Signed-off-by: H. Nikolaus Schaller <hns@xxxxxxxxxxxxx> > Cc: Rob Herring <robh@xxxxxxxxxx> > Cc: devicetree@xxxxxxxxxxxxxxx > --- > .../bindings/display/ingenic-jz4780-hdmi.yaml | 85 +++++++++++++++++++ > 1 file changed, 85 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/ingenic-jz4780-hdmi.yaml > > diff --git a/Documentation/devicetree/bindings/display/ingenic-jz4780-hdmi.yaml b/Documentation/devicetree/bindings/display/ingenic-jz4780-hdmi.yaml > new file mode 100644 > index 000000000000..5e60cdac4f63 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/ingenic-jz4780-hdmi.yaml > @@ -0,0 +1,85 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/ingenic-jz4780-hdmi.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Bindings for Ingenic JZ4780 HDMI Transmitter > + > +maintainers: > + - H. Nikolaus Schaller <hns@xxxxxxxxxxxxx> > + > +description: | > + The HDMI Transmitter in the Ingenic JZ4780 is a Synopsys DesignWare HDMI 1.4 > + TX controller IP with accompanying PHY IP. > + > +allOf: > + - $ref: panel/panel-common.yaml# Is it a panel though? > +properties: > + compatible: > + items: > + - const: ingenic,jz4780-dw-hdmi This can just be a const, there's no need for the items > + > + reg: > + maxItems: 1 > + description: the address & size of the LCD controller registers There's no need for that description, it's obvious enough > + reg-io-width: > + const: 4 If it's fixed, why do you need it in the first place? > + interrupts: > + maxItems: 1 > + description: Specifies the interrupt provided by parent There's no need for that description, it's obvious enough > + clocks: > + maxItems: 2 > + description: Clock specifiers for isrf and iahb clocks This can be defined as clocks: items: - description: isrf - description: iahb A better description about what these clocks are would be nice as well > + clock-names: > + items: > + - const: isfr Is it isfr or isrf? > + - const: iahb > + > + hdmi-regulator: true > + description: Optional regulator to provide +5V at the connector regulators need to be suffixed by -supply You also can just provide the description, you don't need the true there > + ddc-i2c-bus: true ditto > + description: An I2C interface if the internal DDC I2C driver is not to be used > + ports: true If there's a single port, you don't need ports You should also include /schemas/graph.yaml#/$defs/port-base Maxime
Attachment:
signature.asc
Description: PGP signature
