Hi, On Tue, Sep 21, 2021 at 11:06 AM Philip Chen <philipchen@xxxxxxxxxxxx> wrote: > > Replace the direct i2c access (i2c_smbus_* functions) with regmap APIs, > which will simplify the future update on ps8640 driver. > > Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx> > Acked-by: Sam Ravnborg <sam@xxxxxxxxxxxx> > Signed-off-by: Philip Chen <philipchen@xxxxxxxxxxxx> > --- > > (no changes since v4) > > Changes in v4: > - Remove excessive error logging from the probe function > > Changes in v3: > - Fix the nits from v2 review > > Changes in v2: > - Add separate reg map config per page > > drivers/gpu/drm/bridge/parade-ps8640.c | 94 ++++++++++++++++++-------- > 1 file changed, 64 insertions(+), 30 deletions(-) Pushed both patches to drm-misc-next: 13afcdd7277e drm/bridge: parade-ps8640: Add support for AUX channel 692d8db0a5ca drm/bridge: parade-ps8640: Use regmap APIs I made a few whitespace fixes reported by `dim apply-branch` (DRM committer tool) and also re-arranged your Signed-off-by to be above the Reviews/Acks. -Doug