Re: [PATCH][next] drm/rockchip: Remove redundant assignment of pointer connector

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Colin,
Am 22.09.21 um 13:24 schrieb Colin King:
From: Colin Ian King <colin.king@xxxxxxxxxxxxx>

The pointer connector is being assigned a value that is never
read, it is being updated immediately afterwards. The assignment
is redundant and can be removed.

The pointer to the connector is used in rockchip_rgb_fini for drm_connector_cleanup.
It's pretty much the same for the encoder, btw.

Regards,

Alex

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
---
  drivers/gpu/drm/rockchip/rockchip_rgb.c | 1 -
  1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/rockchip/rockchip_rgb.c b/drivers/gpu/drm/rockchip/rockchip_rgb.c
index 09be9678f2bd..18fb84068a64 100644
--- a/drivers/gpu/drm/rockchip/rockchip_rgb.c
+++ b/drivers/gpu/drm/rockchip/rockchip_rgb.c
@@ -150,7 +150,6 @@ struct rockchip_rgb *rockchip_rgb_init(struct device *dev,
  	if (ret)
  		goto err_free_encoder;
- connector = &rgb->connector;
  	connector = drm_bridge_connector_init(rgb->drm_dev, encoder);
  	if (IS_ERR(connector)) {
  		DRM_DEV_ERROR(drm_dev->dev,





[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux