On 18/09/2021 10:13, Jiapeng Chong wrote: > This symbol is not used outside of panfrost_drv.c, so marks it static. > > Fix the following sparse warning: > > drivers/gpu/drm/panfrost/panfrost_drv.c:641:12: warning: symbol > 'mediatek_mt8183_supplies' was not declared. Should it be static? > > drivers/gpu/drm/panfrost/panfrost_drv.c:642:12: warning: symbol > 'mediatek_mt8183_pm_domains' was not declared. Should it be static? > > Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx> > Signed-off-by: Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx> Reviewed-by: Steven Price <steven.price@xxxxxxx> I'll push to drm-misc-next. Thanks, Steve > --- > drivers/gpu/drm/panfrost/panfrost_drv.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c b/drivers/gpu/drm/panfrost/panfrost_drv.c > index 077cbbf..82ad9a6 100644 > --- a/drivers/gpu/drm/panfrost/panfrost_drv.c > +++ b/drivers/gpu/drm/panfrost/panfrost_drv.c > @@ -638,8 +638,8 @@ static int panfrost_remove(struct platform_device *pdev) > .vendor_quirk = panfrost_gpu_amlogic_quirk, > }; > > -const char * const mediatek_mt8183_supplies[] = { "mali", "sram" }; > -const char * const mediatek_mt8183_pm_domains[] = { "core0", "core1", "core2" }; > +static const char * const mediatek_mt8183_supplies[] = { "mali", "sram" }; > +static const char * const mediatek_mt8183_pm_domains[] = { "core0", "core1", "core2" }; > static const struct panfrost_compatible mediatek_mt8183_data = { > .num_supplies = ARRAY_SIZE(mediatek_mt8183_supplies), > .supply_names = mediatek_mt8183_supplies, >