Re: [PATCH v5 2/2] drm/bridge: parade-ps8640: Add support for AUX channel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Philip,
On Sat, Sep 18, 2021 at 10:21:17AM -0700, Philip Chen wrote:
> Implement the first version of AUX support, which will be useful as
> we expand the driver to support varied use cases.
> 
> Signed-off-by: Philip Chen <philipchen@xxxxxxxxxxxx>

Patch is:
Signed-off-by: Sam Ravnborg <sam@xxxxxxxxxxxx>

please consider a few follow-up patches:
1) Replace deprecated drm_bridge_funcs with the _atomic_ variants.
2) Replace the deprecated drm_bridge_chain_pre_enable() with the atomic
   variant.
3) Use pr_() and dev_() logging in favour of DRM_ logging.
   DRM_ logging is deprecated these days and do not belong in bridge
   drivers anyway.

Maxime has a few patches pending for this driver - it would be great if
you could look them up and review them.
Maybe you can get some review in feedback.

	Sam




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux