Hi,
On Wed, Sep 8, 2021 at 2:54 PM Stephen Boyd <swboyd@xxxxxxxxxxxx> wrote:
>
> Quoting Philip Chen (2021-09-08 11:18:05)
> > diff --git a/drivers/gpu/drm/bridge/parade-ps8640.c b/drivers/gpu/drm/bridge/parade-ps8640.c
> > index 685e9c38b2db..a16725dbf912 100644
> > --- a/drivers/gpu/drm/bridge/parade-ps8640.c
> > +++ b/drivers/gpu/drm/bridge/parade-ps8640.c
> > @@ -64,12 +65,29 @@ struct ps8640 {
> > struct drm_bridge *panel_bridge;
> > struct mipi_dsi_device *dsi;
> > struct i2c_client *page[MAX_DEVS];
> > + struct regmap *regmap[MAX_DEVS];
> > struct regulator_bulk_data supplies[2];
> > struct gpio_desc *gpio_reset;
> > struct gpio_desc *gpio_powerdown;
> > bool powered;
> > };
> >
> > +static const struct regmap_range ps8640_volatile_ranges[] = {
> > + { .range_min = 0, .range_max = 0xff },
>
> Is the plan to fill this out later or is 0xff the max register? If it's
> the latter then I think adding the max register to regmap_config is
> simpler.
It's the former.
The real accessible register range is different per page, E.g.:
- For page0, the register range is 0x00 - 0xbf.
- For page1, the register range is 0x00 - 0xff.
- For page2, the register range is 0x80 - 0xff.
Even if we don't specify the accurate per-page register range later,
the default register range here (0x00 - 0xff) can cover the available
registers in each page.
>
> > +};
> > +
> > +static const struct regmap_access_table ps8640_volatile_table = {
> > + .yes_ranges = ps8640_volatile_ranges,
> > + .n_yes_ranges = ARRAY_SIZE(ps8640_volatile_ranges),
> > +};
> > +
> > +static const struct regmap_config ps8640_regmap_config = {
> > + .reg_bits = 8,
> > + .val_bits = 8,
> > + .volatile_table = &ps8640_volatile_table,
> > + .cache_type = REGCACHE_NONE,
> > +};
> > +
> > static inline struct ps8640 *bridge_to_ps8640(struct drm_bridge *e)
> > {
> > return container_of(e, struct ps8640, bridge);
> > @@ -78,13 +96,13 @@ static inline struct ps8640 *bridge_to_ps8640(struct drm_bridge *e)
> > static int ps8640_bridge_vdo_control(struct ps8640 *ps_bridge,
> > const enum ps8640_vdo_control ctrl)
> > {
> > - struct i2c_client *client = ps_bridge->page[PAGE3_DSI_CNTL1];
> > - u8 vdo_ctrl_buf[] = { VDO_CTL_ADD, ctrl };
> > + struct regmap *map = ps_bridge->regmap[PAGE3_DSI_CNTL1];
> > + u8 vdo_ctrl_buf[] = {VDO_CTL_ADD, ctrl};
>
> Nitpick: Add a space after { and before }.
Thanks. Will fix this in the next version.
>
> > int ret;
> >
> > - ret = i2c_smbus_write_i2c_block_data(client, PAGE3_SET_ADD,
> > - sizeof(vdo_ctrl_buf),
> > - vdo_ctrl_buf);
> > + ret = regmap_bulk_write(map, PAGE3_SET_ADD,
> > + vdo_ctrl_buf, sizeof(vdo_ctrl_buf));
> > +
> > if (ret < 0) {
> > DRM_ERROR("failed to %sable VDO: %d\n",
> > ctrl == ENABLE ? "en" : "dis", ret);
