Hi Sam,
On Mon, Sep 06, 2021 at 10:39:21PM +0200, Sam Ravnborg wrote:
> Hi Markus,
>
> On Mon, Sep 06, 2021 at 09:35:29PM +0200, Markus Schneider-Pargmann wrote:
> > This patch adds a DisplayPort driver for the Mediatek mt8195 SoC.
> >
> > It supports both functional units on the mt8195, the embedded
> > DisplayPort as well as the external DisplayPort units. It offers
> > hot-plug-detection, audio up to 8 channels, and DisplayPort 1.4 with up
> > to 4 lanes.
> >
> > This driver is based on an initial version by
> > Jason-JH.Lin <jason-jh.lin@xxxxxxxxxxxx>.
> >
> > Signed-off-by: Markus Schneider-Pargmann <msp@xxxxxxxxxxxx>
> > ---
> >
> > Notes:
> > Changes RFC -> v1:
> > - Removed unused register definitions.
> > - Replaced workqueue with threaded irq.
> > - Removed connector code.
> > - Move to atomic_* drm functions.
> > - General cleanups of the code.
> > - Remove unused select GENERIC_PHY.
> >
> > drivers/gpu/drm/mediatek/Kconfig | 6 +
> > drivers/gpu/drm/mediatek/Makefile | 2 +
> > drivers/gpu/drm/mediatek/mtk_dp.c | 2881 +++++++++++++++++++++++++
> > drivers/gpu/drm/mediatek/mtk_dp_reg.h | 580 +++++
> > 4 files changed, 3469 insertions(+)
> > create mode 100644 drivers/gpu/drm/mediatek/mtk_dp.c
> > create mode 100644 drivers/gpu/drm/mediatek/mtk_dp_reg.h
> >
>
>
> > +
> > +static const struct drm_bridge_funcs mtk_dp_bridge_funcs = {
> > + .atomic_duplicate_state = drm_atomic_helper_bridge_duplicate_state,
> > + .atomic_destroy_state = drm_atomic_helper_bridge_destroy_state,
> > + .atomic_reset = drm_atomic_helper_bridge_reset,
> > + .attach = mtk_dp_bridge_attach,
> > + .detach = mtk_dp_bridge_detach,
> > + .pre_enable = mtk_dp_bridge_pre_enable,
> Use the atomic variant here as pre_enable is deprecated.
>
> > + .atomic_enable = mtk_dp_bridge_atomic_enable,
> > + .atomic_disable = mtk_dp_bridge_atomic_disable,
> > + .post_disable = mtk_dp_bridge_post_disable,
> Use the atomic variant here as .post_disable is deprecated.
Thanks, I got rid of both pre_enable and post_disable as well now.
>
> > + .get_edid = mtk_dp_get_edid,
> > + .detect = mtk_dp_bdg_detect,
> > +};
>
> Everything else I skimmed looked fine. But it was a quick skim so..
Thanks for taking the time to have a look.
Best,
Markus
