On Tue, Sep 7, 2021 at 4:01 AM Christian König <ckoenig.leichtzumerken@xxxxxxxxx> wrote: > > Fix the remaining warnings and finally enable this. > > v2: add caching enum link > > Signed-off-by: Christian König <christian.koenig@xxxxxxx> > Reviewed-by: Matthew Auld <matthew.auld@xxxxxxxxx> Reviewed-by: Alex Deucher <alexander.deucher@xxxxxxx> > --- > Documentation/gpu/drm-mm.rst | 9 +++++++++ > include/drm/ttm/ttm_tt.h | 11 ++++++++--- > 2 files changed, 17 insertions(+), 3 deletions(-) > > diff --git a/Documentation/gpu/drm-mm.rst b/Documentation/gpu/drm-mm.rst > index 1c9930fb5e7d..69c4a20b95d0 100644 > --- a/Documentation/gpu/drm-mm.rst > +++ b/Documentation/gpu/drm-mm.rst > @@ -58,6 +58,15 @@ TTM resource object reference > .. kernel-doc:: drivers/gpu/drm/ttm/ttm_resource.c > :export: > > +TTM TT object reference > +----------------------- > + > +.. kernel-doc:: include/drm/ttm/ttm_tt.h > + :internal: > + > +.. kernel-doc:: drivers/gpu/drm/ttm/ttm_tt.c > + :export: > + > The Graphics Execution Manager (GEM) > ==================================== > > diff --git a/include/drm/ttm/ttm_tt.h b/include/drm/ttm/ttm_tt.h > index e402dab1d0f6..b3963ab12e1f 100644 > --- a/include/drm/ttm/ttm_tt.h > +++ b/include/drm/ttm/ttm_tt.h > @@ -54,7 +54,7 @@ struct ttm_operation_ctx; > * @dma_address: The DMA (bus) addresses of the pages > * @swap_storage: Pointer to shmem struct file for swap storage. > * @pages_list: used by some page allocation backend > - * @caching: The current caching state of the pages. > + * @caching: The current caching state of the pages, see enum ttm_caching. > * > * This is a structure holding the pages, caching- and aperture binding > * status for a buffer object that isn't backed by fixed (VRAM / AGP) > @@ -126,8 +126,9 @@ int ttm_sg_tt_init(struct ttm_tt *ttm_dma, struct ttm_buffer_object *bo, > void ttm_tt_fini(struct ttm_tt *ttm); > > /** > - * ttm_ttm_destroy: > + * ttm_tt_destroy: > * > + * @bdev: the ttm_device this object belongs to > * @ttm: The struct ttm_tt. > * > * Unbind, unpopulate and destroy common struct ttm_tt. > @@ -148,15 +149,19 @@ int ttm_tt_swapout(struct ttm_device *bdev, struct ttm_tt *ttm, > /** > * ttm_tt_populate - allocate pages for a ttm > * > + * @bdev: the ttm_device this object belongs to > * @ttm: Pointer to the ttm_tt structure > + * @ctx: operation context for populating the tt object. > * > * Calls the driver method to allocate pages for a ttm > */ > -int ttm_tt_populate(struct ttm_device *bdev, struct ttm_tt *ttm, struct ttm_operation_ctx *ctx); > +int ttm_tt_populate(struct ttm_device *bdev, struct ttm_tt *ttm, > + struct ttm_operation_ctx *ctx); > > /** > * ttm_tt_unpopulate - free pages from a ttm > * > + * @bdev: the ttm_device this object belongs to > * @ttm: Pointer to the ttm_tt structure > * > * Calls the driver method to free all pages from a ttm > -- > 2.25.1 >