Hi Paulo, On Fri, Dec 7, 2012 at 4:11 PM, Paulo Zanoni <przanoni@xxxxxxxxx> wrote: > From: Paulo Zanoni <paulo.r.zanoni@xxxxxxxxx> > > Use the generic HDMI infoframe helpers to get rid of the duplicate > implementation in the i915 driver. > > This patch is based on the initial patch by Thierry Reding, but with a > different approach. > > TODO: > - The SDVO part is totally untested. I am not sure if the buffer > size on the SDVO code must be a multiple of 4. > - The HDMI part was tested only on SNB/CPT. > - The patch is forcing pixel_repeat to 1 so I can properly test the > patch. Remove this before the final version. > - The correctnes of this patch depends on a fix on patch "video: add > Generic HDMI infoframe helpers" > > Signed-off-by: Paulo Zanoni <paulo.r.zanoni@xxxxxxxxx> I like what this looks like, so I think we have a rough plan for integrating the proposed hdmi infoframe helpers into i915. Some minor bikeshedding left, but we can look at this after your big vacation in 2013. For reference my bikeshed: - Maybe extract the type argument sprinkling into a prep patch, that way it's even more clear what's changing (and that very little changes). + uint8_t buffer[32]; /* will be read as uint32_t, so 32, not 30 */ - ROUND_UP(30, sizeof(uint32_t)) and maybe use #defines for 30. Cheers, Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
