Hi Philipp, Thanks for the review. I will base on Enric's patchset in my next revision. Regards, Nancy On Wed, 2021-08-25 at 12:46 +0200, Philipp Zabel wrote: > Hi, > > On Wed, 2021-08-25 at 18:05 +0800, Nancy.Lin wrote: > > Among other features the mmsys driver should implement a reset > > controller to be able to reset different bits from their space. > > > > For MT8195 vdosys1, many async modules need to reset after > > the display pipe stops and restart. > > > > Signed-off-by: Nancy.Lin <nancy.lin@xxxxxxxxxxxx> > > --- > > drivers/soc/mediatek/mt8195-mmsys.h | 1 + > > drivers/soc/mediatek/mtk-mmsys.c | 76 > > +++++++++++++++++++++++++++++ > > Cc: Enric - this patch clashes with [1], please coordinate. > > [1] > https://urldefense.com/v3/__https://lore.kernel.org/linux-arm-kernel/20210825122613.v3.6.I15e2419141a69b2e5c7e700c34d92a69df47e04d@changeid/__;!!CTRNKA9wMg0ARbw!yhYDk3anhefxrYOCQBcUgiosJbqdIRCV2IfO2toZ3FZi4t-AcCNOcE5xeK-IV0MC$ > > > regards > Philipp