Re: [PATCH] drm/msm: remove unneeded variable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 31/08/2021 14:51, cgel.zte@xxxxxxxxx wrote:
From: Chi Minghao <chi.minghao@xxxxxxxxxx>

Fix the following coccicheck REVIEW:
./drivers/gpu/drm/msm/edp/edp_ctrl.c:1245:5-8 Unneeded variable

Reported-by: Zeal Robot <zealci@xxxxxxxxxx>
Signed-off-by: Chi Minghao <chi.minghao@xxxxxxxxxx>

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>

Glancing on msm/edp, as it was never supported by the in-kernel dts I wonder: maybe we should drop it completely? If the need arises the removal can be reverted anytime.

Does anybody hacking 8084/8074/8974 support has eDP port access?

---
  drivers/gpu/drm/msm/edp/edp_ctrl.c | 4 +---
  1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/msm/edp/edp_ctrl.c b/drivers/gpu/drm/msm/edp/edp_ctrl.c
index 4fb397ee7c84..3610e26e62fa 100644
--- a/drivers/gpu/drm/msm/edp/edp_ctrl.c
+++ b/drivers/gpu/drm/msm/edp/edp_ctrl.c
@@ -1242,8 +1242,6 @@ bool msm_edp_ctrl_panel_connected(struct edp_ctrl *ctrl)
  int msm_edp_ctrl_get_panel_info(struct edp_ctrl *ctrl,
  		struct drm_connector *connector, struct edid **edid)
  {
-	int ret = 0;
-
  	mutex_lock(&ctrl->dev_mutex);
if (ctrl->edid) {
@@ -1278,7 +1276,7 @@ int msm_edp_ctrl_get_panel_info(struct edp_ctrl *ctrl,
  	}
  unlock_ret:
  	mutex_unlock(&ctrl->dev_mutex);
-	return ret;
+	return 0;
  }
int msm_edp_ctrl_timing_cfg(struct edp_ctrl *ctrl,



--
With best wishes
Dmitry



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux