On Mon, Aug 23, 2021 at 01:15:20PM +0200, Thomas Hellström wrote: > On Mon, 2021-08-23 at 13:05 +0200, Christian König wrote: > > Adding Thomas on CC as well. > > > > Just a gentle ping. I think the patch set makes sense now. > > > > Regards, > > Christian. > > > > Am 28.07.21 um 15:05 schrieb Christian König: > > > Doing this in vmw_ttm_destroy() is to late. > > > > > > It turned out that this is not a good idea at all because it leaves > > > pointers > > > to freed up system memory pages in the GART tables of the drivers. > > > > > > Signed-off-by: Christian König <christian.koenig@xxxxxxx> > > > --- > > > drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c | 9 +++------ > > > 1 file changed, 3 insertions(+), 6 deletions(-) > > > > > Reviewed-by: Thomas Hellström <thomas.hellstrom@xxxxxxxxxxxxxxx> For next time around I think recording a bit more of the discussions and git history in these would be really good. At least I'd like to get more people ramped up on ttm work, and for that to work out things need to be a bit more accessible ... The above commit message is pretty much useless if you ever hit it in a git blame, if you haven't been involved in any of these discussions. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
