On Tue, 27 Jul 2021, Daniel Vetter <daniel.vetter@xxxxxxxx> wrote: > +static void __exit i915_exit(void) > +{ > + int i; > + > + for (i = init_progress - 1; i >= 0; i--) { > + GEM_BUG_ON(i >= ARRAY_SIZE(init_funcs)); Not introduced by you, but it's kind of silly we're using GEM_BUG_ON() in generic driver code. BR, Jani. > + if (init_funcs[i].exit) > + init_funcs[i].exit(); > + } > +} -- Jani Nikula, Intel Open Source Graphics Center