Hi, On Fri, Aug 20, 2021 at 4:22 PM Philip Chen <philipchen@xxxxxxxxxxxx> wrote: > > From: Philip Chen <philipchen@xxxxxxxxxxxx> > > Reorg the macros as follows: > (1) Group the registers on the same page together. > (2) Group the register and its bit operation together while indenting > the macros of the bit operation with one space. > > Also fix a misnomer for the number of mipi data lanes. > > Signed-off-by: Philip Chen <philipchen@xxxxxxxxxxxx> > Signed-off-by: Philip Chen <philipchen@xxxxxxxxxx> > --- > > drivers/gpu/drm/bridge/parade-ps8640.c | 18 ++++++++++-------- > 1 file changed, 10 insertions(+), 8 deletions(-) This seems fine to me other than the slightly mixed up Signed-off-by lines. I think that the git config from wherever you ran "git send-email" had your @google.com address even if you authored the patch with your @chomium.org address. Once that's fixed then I'm happy to add my Reviewed-by and (unless someone objects) I'll plan to apply this patch to drm-misc-next. -Doug