Hi Chun-Kuang, Thanks for the review. On Thu, 2021-08-19 at 23:00 +0800, Chun-Kuang Hu wrote: > Hi, Jason: > > jason-jh.lin <jason-jh.lin@xxxxxxxxxxxx> 於 2021年8月19日 週四 上午10:23寫道： > > > > 1. There are 2 mmsys, namely vdosys0 and vdosys1 in mt8195. > > Each of them is bound to a display pipeline, so add their > > definition in mtk-mmsys documentation with 2 compatibles. > > > > 2. Add description for power-domain property. > > > > Signed-off-by: jason-jh.lin <jason-jh.lin@xxxxxxxxxxxx> > > --- > > this patch is base on [1][2] > > > > [1] dt-bindings: arm: mediatek: mmsys: convert to YAML format > > - > > https://urldefense.com/v3/__https://patchwork.kernel.org/project/linux-mediatek/patch/20210519161847.3747352-1-fparent@xxxxxxxxxxxx/__;!!CTRNKA9wMg0ARbw!w8o5bmoiLe92jLT1-_lV_0q9mlcvIOcACUoTI-VjaVv3tGtKr414AQyDnf1ywivw9BHJ$ > > > > [2] dt-bindings: arm: mediatek: mmsys: add MT8365 SoC binding > > - > > https://urldefense.com/v3/__https://patchwork.kernel.org/project/linux-mediatek/patch/20210519161847.3747352-2-fparent@xxxxxxxxxxxx/__;!!CTRNKA9wMg0ARbw!w8o5bmoiLe92jLT1-_lV_0q9mlcvIOcACUoTI-VjaVv3tGtKr414AQyDnf1ywmNF79JZ$ > > > > --- > > .../devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml | 8 > > ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git > > a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yam > > l > > b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yam > > l > > index 2d4ff0ce387b..68cb330d7595 100644 > > --- > > a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yam > > l > > +++ > > b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yam > > l > > @@ -30,6 +30,8 @@ properties: > > - mediatek,mt8173-mmsys > > - mediatek,mt8183-mmsys > > - mediatek,mt8365-mmsys > > + - mediatek,mt8195-vdosys0 > > + - mediatek,mt8195-vdosys1 > > - const: syscon > > - items: > > - const: mediatek,mt7623-mmsys > > @@ -39,6 +41,12 @@ properties: > > reg: > > maxItems: 1 > > > > + power-domains: > > + description: > > + A phandle and PM domain specifier as defined by bindings > > + of the power controller specified by phandle. See > > + Documentation/devicetree/bindings/power/power-domain.yaml > > for details. > > + > > This patch is about mt8195, but mt8173 mmsys also has power domain. > So > move this part to another patch. > > Regards, > Chun-Kuang. > OK, I'll move this part to another patch. Regards, Jason-JH.Lin > > > "#clock-cells": > > const: 1 > > > > -- > > 2.18.0 > > -- Jason-JH Lin <jason-jh.lin@xxxxxxxxxxxx>
