Re: [PATCH v3 15/15] drm/mediatek: add mediatek-drm of vdosys1 support for MT8195

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Chun-Kuang,
	Thanks for the review.

On Sun, 2021-08-22 at 09:14 +0800, Chun-Kuang Hu wrote:
> Hi, Nancy:
> 
> Nancy.Lin <nancy.lin@xxxxxxxxxxxx> 於 2021年8月18日 週三 下午5:18寫道:
> > 
> > Add driver data of mt8195 vdosys1 to mediatek-drm and modify drm
> > for
> > multi-mmsys support. The two mmsys (vdosys0 and vdosys1) will bring
> > up two drm drivers, only one drm driver register as the drm device.
> > Each drm driver binds its own component. The first bind drm driver
> > will allocate the drm device, and the last bind drm driver
> > registers
> > the drm device to drm core. Each crtc path is created with the
> > corresponding drm driver data.
> > 
> > Signed-off-by: Nancy.Lin <nancy.lin@xxxxxxxxxxxx>
> > 
> > 
> > +static const struct mtk_ddp_comp_funcs ddp_ovl_adaptor = {
> > +       .clk_enable = mtk_ethdr_clk_enable,
> > +       .clk_disable = mtk_ethdr_clk_disable,
> > +       .config = mtk_ethdr_config,
> > +       .start = mtk_ethdr_start,
> > +       .stop = mtk_ethdr_stop,
> > +       .layer_nr = mtk_ethdr_layer_nr,
> > +       .layer_config = mtk_ethdr_layer_config,
> > +       .enable_vblank = mtk_ethdr_enable_vblank,
> > +       .disable_vblank = mtk_ethdr_disable_vblank,
> > +};
> 
> I think ethdr is inside the group of ovl_adpator. I preter this
> function is implemented by ovl_adaptor, and ovl_adaptor control rdma,
> merge, ethdr.
> 
> Regards,
> Chun-Kuang.
> 
OK, I will change it to the ovl_adaptor function.

> > +
> > 




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux