On 18.08.2021 16:20, Daniel Vetter wrote: > On Thu, Jul 01, 2021 at 05:55:11PM +0200, Michal Wajdeczko wrote: >> Instead of plain error value (%d) print more user friendly error >> name (%pe). >> >> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@xxxxxxxxx> >> --- >> drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 8 ++++---- >> 1 file changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c >> index a26bb55c0898..18d52c39f0c2 100644 >> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c >> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c >> @@ -167,8 +167,8 @@ static int ct_register_buffer(struct intel_guc_ct *ct, u32 type, >> err = guc_action_register_ct_buffer(ct_to_guc(ct), type, >> desc_addr, buff_addr, size); >> if (unlikely(err)) >> - CT_ERROR(ct, "Failed to register %s buffer (err=%d)\n", >> - guc_ct_buffer_type_to_str(type), err); >> + CT_ERROR(ct, "Failed to register %s buffer (%pe)\n", >> + guc_ct_buffer_type_to_str(type), ERR_PTR(err)); > > errname() is what you want here, not this convoluted jumping through hoops > to fake an error pointer. nope, I was already trying that shortcut, but errname() is not exported so we fail with ERROR: modpost: "errname" [drivers/gpu/drm/i915/i915.ko] undefined! so unless we add that export we must follow initial approach [1] -Michal [1] https://cgit.freedesktop.org/drm/drm-tip/commit/?id=57f5677e535ba24b8926a7125be2ef8d7f09323c > > With that: Reviewed-by: Daniel Vetter <daniel.vetter@xxxxxxxx> >> return err; >> } >> >> @@ -195,8 +195,8 @@ static int ct_deregister_buffer(struct intel_guc_ct *ct, u32 type) >> int err = guc_action_deregister_ct_buffer(ct_to_guc(ct), type); >> >> if (unlikely(err)) >> - CT_ERROR(ct, "Failed to deregister %s buffer (err=%d)\n", >> - guc_ct_buffer_type_to_str(type), err); >> + CT_ERROR(ct, "Failed to deregister %s buffer (%pe)\n", >> + guc_ct_buffer_type_to_str(type), ERR_PTR(err)); >> return err; >> } >> >> -- >> 2.25.1 >> >> _______________________________________________ >> Intel-gfx mailing list >> Intel-gfx@xxxxxxxxxxxxxxxxxxxxx >> https://lists.freedesktop.org/mailman/listinfo/intel-gfx >