Hi, On Wed, Aug 18, 2021 at 12:45:46PM +0800, CK Hu wrote: > Hi, Markus: > > On Mon, 2021-08-16 at 21:25 +0200, Markus Schneider-Pargmann wrote: > > DP_INTF is similar to the actual dpi. They differ in some points > > regarding registers and what needs to be set but the function blocks > > itself are similar in design. > > > > Signed-off-by: Markus Schneider-Pargmann <msp@xxxxxxxxxxxx> > > --- > > .../display/mediatek/mediatek,dpi.yaml | 48 ++++++++++++++++--- > > 1 file changed, 42 insertions(+), 6 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml > > index dd2896a40ff0..de4bdacd83ac 100644 > > --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml > > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml > > @@ -4,7 +4,7 @@ > > $id: https://urldefense.com/v3/__http://devicetree.org/schemas/display/mediatek/mediatek,dpi.yaml*__;Iw!!CTRNKA9wMg0ARbw!z5TyPvbq3ZLHjRPscOHigUMlikjhtJMFrEQqemcjQZa4NaXBE9tzMnDFMa1qYg$ > > $schema: https://urldefense.com/v3/__http://devicetree.org/meta-schemas/core.yaml*__;Iw!!CTRNKA9wMg0ARbw!z5TyPvbq3ZLHjRPscOHigUMlikjhtJMFrEQqemcjQZa4NaXBE9tzMnAjuBCxsg$ > > > > -title: mediatek DPI Controller Device Tree Bindings > > +title: mediatek DPI/DP_INTF Controller Device Tree Bindings > > > > maintainers: > > - CK Hu <ck.hu@xxxxxxxxxxxx> > > @@ -13,7 +13,8 @@ maintainers: > > description: | > > The Mediatek DPI function block is a sink of the display subsystem and > > provides 8-bit RGB/YUV444 or 8/10/10-bit YUV422 pixel data on a parallel > > - output bus. > > + output bus. The Mediatek DP_INTF is a similar function block that is > > + connected to the (embedded) display port function block. > > > > properties: > > compatible: > > @@ -23,6 +24,7 @@ properties: > > - mediatek,mt8173-dpi > > - mediatek,mt8183-dpi > > - mediatek,mt8192-dpi > > + - mediatek,mt8195-dpintf > > I've reviewed the modification in driver, it seems that dpintf is almost > the same as dpi. Why use the name "dpintf"? I could accept this name > only it's defined by hardware data sheet. Yes the data sheet makes a distinction between DPI and DP_INTF. mt8195 has a DPI unit as well. DP_INTF has a slightly different feature set and also uses slightly different register bits. Best, Markus > > Regards, > CK > > > > > reg: > > maxItems: 1 > > @@ -37,10 +39,11 @@ properties: > > - description: DPI PLL > > > > clock-names: > > - items: > > - - const: pixel > > - - const: engine > > - - const: pll > > + description: > > + For dpi clocks pixel, engine and pll are required. For dpintf pixel, pll, > > + pll_d2, pll_d4, pll_d8, pll_d16, hf_fmm, hf_fdp are required. > > + minItems: 3 > > + maxItems: 8 > > > > pinctrl-0: true > > pinctrl-1: true > > @@ -64,6 +67,39 @@ required: > > - clock-names > > - port > > > > +allOf: > > + - if: > > + properties: > > + compatible: > > + contains: > > + enum: > > + - mediatek,mt8195-dpintf > > + then: > > + properties: > > + clocks: > > + minItems: 8 > > + maxItems: 8 > > + clock-names: > > + items: > > + - const: pixel > > + - const: pll > > + - const: pll_d2 > > + - const: pll_d4 > > + - const: pll_d8 > > + - const: pll_d16 > > + - const: hf_fmm > > + - const: hf_fdp > > + else: > > + properties: > > + clocks: > > + minItems: 3 > > + maxItems: 3 > > + clock-names: > > + items: > > + - const: pixel > > + - const: engine > > + - const: pll > > + > > additionalProperties: false > > > > examples: >
