On Mon, 16 Aug 2021, Jackie Liu <liu.yun@xxxxxxxxx> wrote: > After commit f611b1e7624c, we change select FB > to depends on FB. And obviously you should cite the commit in the original patch and Cc the author! BR, Jani. > > How about this： > > diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig > index 7ff89690a976..cd129d96e649 100644 > --- a/drivers/gpu/drm/Kconfig > +++ b/drivers/gpu/drm/Kconfig > @@ -98,7 +98,7 @@ config DRM_DEBUG_DP_MST_TOPOLOGY_REFS > config DRM_FBDEV_EMULATION > bool "Enable legacy fbdev support for your modesetting driver" > depends on DRM > - depends on FB > + depends on FB && FB != m > select DRM_KMS_HELPER > select FB_CFB_FILLRECT > select FB_CFB_COPYAREA > > -- > Jackie Liu > > 在 2021/8/16 下午3:01, Jani Nikula 写道: >> On Mon, 16 Aug 2021, Jackie Liu <liu.yun@xxxxxxxxx> wrote: >>> From: Jackie Liu <liuyun01@xxxxxxxxxx> >>> >>> When CONFIG_DRM_FBDEV_EMULATION is compiled to y and CONFIG_FB is m, the >>> compilation will fail. we need make that dependency explicit. >> >> What's the failure mode? Using select here is a bad idea. >> >> BR, >> Jani. >> >>> >>> Reported-by: k2ci <kernel-bot@xxxxxxxxxx> >>> Signed-off-by: Jackie Liu <liuyun01@xxxxxxxxxx> >>> --- >>> drivers/gpu/drm/Kconfig | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig >>> index 7ff89690a976..346a518b5119 100644 >>> --- a/drivers/gpu/drm/Kconfig >>> +++ b/drivers/gpu/drm/Kconfig >>> @@ -98,7 +98,7 @@ config DRM_DEBUG_DP_MST_TOPOLOGY_REFS >>> config DRM_FBDEV_EMULATION >>> bool "Enable legacy fbdev support for your modesetting driver" >>> depends on DRM >>> - depends on FB >>> + select FB >>> select DRM_KMS_HELPER >>> select FB_CFB_FILLRECT >>> select FB_CFB_COPYAREA >> -- Jani Nikula, Intel Open Source Graphics Center
