Tested-by: Huacai Chen <chenhuacai@xxxxxxxxxxx> On Wed, Aug 11, 2021 at 6:42 AM Dan Moulding <dmoulding@xxxxxx> wrote: > > In 69de4421bb4c ("drm/ttm: Initialize debugfs from > ttm_global_init()"), ttm_global_init was changed so that if creation > of the debugfs global root directory fails, ttm_global_init will bail > out early and return an error, leading to initialization failure of > DRM drivers. However, not every system will be using debugfs. On such > a system, debugfs directory creation can be expected to fail, but DRM > drivers must still be usable. This changes it so that if creation of > TTM's debugfs root directory fails, then no biggie: keep calm and > carry on. > > Fixes: 69de4421bb4c ("drm/ttm: Initialize debugfs from ttm_global_init()") > Signed-off-by: Dan Moulding <dmoulding@xxxxxx> > --- > drivers/gpu/drm/ttm/ttm_device.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/ttm/ttm_device.c b/drivers/gpu/drm/ttm/ttm_device.c > index 74e3b460132b..2df59b3c2ea1 100644 > --- a/drivers/gpu/drm/ttm/ttm_device.c > +++ b/drivers/gpu/drm/ttm/ttm_device.c > @@ -78,9 +78,7 @@ static int ttm_global_init(void) > > ttm_debugfs_root = debugfs_create_dir("ttm", NULL); > if (IS_ERR(ttm_debugfs_root)) { > - ret = PTR_ERR(ttm_debugfs_root); > ttm_debugfs_root = NULL; > - goto out; > } > > /* Limit the number of pages in the pool to about 50% of the total > -- > 2.31.1 >