Re: [PATCH 1/8] drm/ingenic: Remove dead code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Joe,

Le dim., août 8 2021 at 11:27:34 -0700, Joe Perches <joe@xxxxxxxxxxx> a écrit :
On Sun, 2021-08-08 at 19:58 +0200, Thomas Zimmermann wrote:

 Am 08.08.21 um 15:45 schrieb Paul Cercueil:
> The priv->ipu_plane would get a different value further down the code,
 > without the first assigned value being read first; so the first
 > assignation can be dropped.
 >
 > Signed-off-by: Paul Cercueil <paul@xxxxxxxxxxxxxxx>

 Acked-by: Thomas Zimmermann <tzimmermann@xxxxxxx>

I think this is at best an incomplete description.

How is it known that this priv->ipu_plane assignment isn't
necessary for any path of any failure path after this assignment
and before the new assignment?

It is only used in the .atomic_begin and .atomic_check callbacks of the CRTC. These will only ever be called after the call to drm_dev_register() which happens at the end of the probe function.

Cheers,
-Paul

> diff --git a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
[]
> @@ -984,9 +984,6 @@ static int ingenic_drm_bind(struct device *dev, bool has_components)
 >   	priv->dma_hwdescs->hwdesc_pal.cmd = JZ_LCD_CMD_ENABLE_PAL
 >   		| (sizeof(priv->dma_hwdescs->palette) / 4);
 >
 > -	if (soc_info->has_osd)
 > -		priv->ipu_plane = drm_plane_from_index(drm, 0);
 > -
 >   	primary = priv->soc_info->has_osd ? &priv->f1 : &priv->f0;
 >
 >   	drm_plane_helper_add(primary, &ingenic_drm_plane_helper_funcs);
 >









[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux