On Thu, Aug 05, 2021 at 02:30:35PM +0300, Andy Shevchenko wrote: > On Thu, Aug 5, 2021 at 2:18 PM Greg Kroah-Hartman > <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > On Sun, Aug 01, 2021 at 02:40:40PM +0300, Andy Shevchenko wrote: > > > On Sun, Aug 1, 2021 at 11:53 AM Len Baker <len.baker@xxxxxxx> wrote: > > > > > > > > strcpy() performs no bounds checking on the destination buffer. This > > > > could result in linear overflows beyond the end of the buffer, leading > > > > to all kinds of misbehaviors. So, this serie removes all strcpy uses > > > > from the "staging/fbtft" subsystem. > > > > > > > > Also, refactor the code a bit to follow the kernel coding-style and > > > > avoid unnecessary variable initialization. > > > > > > I don't see patch 3 (even on lore.kernel.org). > > > > > > Greg, Geert, does it make sense to move this driver outside of staging? > > > > If you clean up everything that needs to be done, yes, please do. > > Do we have a clear TODO for that? > > The current one has the item which is not feasible to achieve in > reasonable time. Some of those drivers won't be converted to tiny DRM. > So the idea is to keep this out of staging in the maintenance phase > (as it currently states, i.e. no new drivers accepted). For the rest > I'm not sure what else can be done (checkpatch? coccinelle?). > Actually the first sentence in this paragraph is a motivation for > moving out of staging. Take it up with the DRM developers/maintainers. If they approve for this to move out of staging without being converted over to use tiny DRM, then I am fine to move it out. thnks, greg k-h
