Hi Douglas, On Fri, Jul 30, 2021 at 02:26:19PM -0700, Douglas Anderson wrote: > The goal of this patch series is to move away from hardcoding exact > eDP panels in device tree files. As discussed in the various patches > in this series (I'm not repeating everything here), most eDP panels > are 99% probable and we can get that last 1% by allowing two "power > up" delays to be specified in the device tree file and then using the > panel ID (found in the EDID) to look up additional power sequencing > delays for the panel. Have you considered a new driver for edp panels? panel-edp.c? There will be some duplicate code from pnale-simple - but the same can be said by the other panel drivers too. In the end I think it is better to separate them so we end up with two less complex panel drivers rather than one do-it-all panel driver. I have not looked in detail how this would look like, but my first impression is that we should split it out. Sam
