On Wed, Jul 28, 2021 at 09:45:51AM -0700, Douglas Anderson wrote: > > The overall goal of this series is to make the Samsung ATNA33XC20 > panel work more properly. As part of this, we have: > * A bugfix for the recently abstracted DP AUX backlight code. > * A bugfix for the sequencing of the ti-sn65dsi86 bridge driver. > * Removal of the panel from panel-simple and moving it to its own > driver. > > If the bugfixes look good but the rest of the series needs work then > those could land early on their own. There's no real compile time > dependency on the bugfixes, things are just glitchier without them. > > NOTE: this series will (slightly) conflict with my other recent series > making eDP panels probable [1]. The conflict is easy to resolve and > I'm happy to repost either once the other lands. It should be noted > that the fact that the Samsung ATNA33XC20 needs its own panel driver > means that it _can't_ handled as a probed driver. I think this is > fine, at least for now. I don't think it would be easy to make a > unified design with this panel and other panels given that it's an > AMOLED panel and has a whole bunch of different components on board. > > [1] https://lore.kernel.org/r/20210723002146.1962910-1-dianders@xxxxxxxxxxxx/ > > > Douglas Anderson (6): Hi Doug, Thanks for the patchset, it all looks to me. For all 6: Reviewed-by: Sean Paul <seanpaul@xxxxxxxxxxxx> Sean > drm/dp: Don't zero PWMGEN_BIT_COUNT when driver_pwm_freq_hz not > specified > drm/bridge: ti-sn65dsi86: Fix power off sequence > drm/bridge: ti-sn65dsi86: Add some 100 us delays > Revert "drm/panel-simple: Add Samsung ATNA33XC20" > Revert "drm/panel-simple: Support for delays between GPIO & regulator" > drm/panel: atna33xc20: Introduce the Samsung ATNA33XC20 panel > > drivers/gpu/drm/bridge/ti-sn65dsi86.c | 17 +- > drivers/gpu/drm/drm_dp_helper.c | 10 +- > drivers/gpu/drm/panel/Kconfig | 12 + > drivers/gpu/drm/panel/Makefile | 1 + > .../gpu/drm/panel/panel-samsung-atna33xc20.c | 366 ++++++++++++++++++ > drivers/gpu/drm/panel/panel-simple.c | 61 --- > 6 files changed, 398 insertions(+), 69 deletions(-) > create mode 100644 drivers/gpu/drm/panel/panel-samsung-atna33xc20.c > > -- > 2.32.0.432.gabb21c7263-goog > -- Sean Paul, Software Engineer, Google / Chromium OS
