Re: [Linaro-mm-sig] [PATCH v4 03/18] drm/sched: Add dependency tracking

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 27.07.21 um 13:09 schrieb Daniel Vetter:
Adding a few more people to this bikeshed.

On Mon, Jul 12, 2021 at 10:02 PM Daniel Vetter <daniel.vetter@xxxxxxxx> wrote:

@@ -349,6 +367,13 @@ int drm_sched_job_init(struct drm_sched_job *job,
                        struct drm_sched_entity *entity,
                        void *owner);
  void drm_sched_job_arm(struct drm_sched_job *job);
+int drm_sched_job_await_fence(struct drm_sched_job *job,
+                             struct dma_fence *fence);
+int drm_sched_job_await_implicit(struct drm_sched_job *job,
+                                struct drm_gem_object *obj,
+                                bool write);
+
+
I'm still waiting on the paint delivery for these two functions so I
can finish this shed.

Well I wouldn't call that bike shedding, good names are important.

Just imaging we would have called the exclusive-fence write-fence instead.

What speaks against calling them add_dependency() and _add_implicit_depencencies() ?

Regards,
Christian.


Thanks, Daniel

  void drm_sched_entity_modify_sched(struct drm_sched_entity *entity,
                                     struct drm_gpu_scheduler **sched_list,
                                     unsigned int num_sched_list);
--
2.32.0






[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux