On Tue, Jul 27, 2021 at 05:31:22PM -0700, Anitha Chrisanthus wrote:
> On KMB, ADV bridge must be programmed and powered on prior to
> MIPI DSI HW initialization.
>
> Fixes: 98521f4d4b4c ("drm/kmb: Mipi DSI part of the display driver")
> Signed-off-by: Anitha Chrisanthus <anitha.chrisanthus@xxxxxxxxx>
> ---
> drivers/gpu/drm/kmb/kmb_dsi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/kmb/kmb_dsi.c b/drivers/gpu/drm/kmb/kmb_dsi.c
> index 5bc6c84073a3..1cca0fe6f35f 100644
> --- a/drivers/gpu/drm/kmb/kmb_dsi.c
> +++ b/drivers/gpu/drm/kmb/kmb_dsi.c
> @@ -1341,6 +1341,7 @@ static void connect_lcd_to_mipi(struct kmb_dsi *kmb_dsi)
> return;
> }
>
> + drm_bridge_chain_enable(adv_bridge);
This function is about to be deleted.
Please use the atomic variant drm_atomic_bridge_chain_enable()
Also, I cannot see why this display driver has to call this.
Something else seems missing here...
Sam
