Re: [RESEND PATCH v6 11/14] drm/mst: Convert debug printers to debug category printers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Reviewed-by: Lyude Paul <lyude@xxxxxxxxxx>

On Wed, 2021-07-21 at 13:55 -0400, Sean Paul wrote:
> From: Sean Paul <seanpaul@xxxxxxxxxxxx>
> 
> The printers in dp_mst are meant to be gated on DRM_UT_DP, so use the
> debug category printer to avoid dumping mst transactions to the wrong
> place.
> 
> Signed-off-by: Sean Paul <seanpaul@xxxxxxxxxxxx>
> Link:
> https://patchwork.freedesktop.org/patch/msgid/20200608210505.48519-12-sean@xxxxxxxxxx
>  #v5
> 
> Changes in v5:
> -Added to the set
> Changes in v6:
> -None
> Reviewed-by: Lyude Paul <lyude@xxxxxxxxxx>
> ---
>  drivers/gpu/drm/drm_dp_mst_topology.c | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c
> b/drivers/gpu/drm/drm_dp_mst_topology.c
> index ad0795afc21c..b1dddecad4c6 100644
> --- a/drivers/gpu/drm/drm_dp_mst_topology.c
> +++ b/drivers/gpu/drm/drm_dp_mst_topology.c
> @@ -1356,7 +1356,8 @@ static int drm_dp_mst_wait_tx_reply(struct
> drm_dp_mst_branch *mstb,
>         }
>  out:
>         if (unlikely(ret == -EIO) && drm_debug_enabled(DRM_UT_DP)) {
> -               struct drm_printer p = drm_debug_printer(DBG_PREFIX);
> +               struct drm_printer p = drm_debug_category_printer(DRM_UT_DP,
> +                                                                
> DBG_PREFIX);
>  
>                 drm_dp_mst_dump_sideband_msg_tx(&p, txmsg);
>         }
> @@ -2873,7 +2874,8 @@ static int process_single_tx_qlock(struct
> drm_dp_mst_topology_mgr *mgr,
>  
>         ret = drm_dp_send_sideband_msg(mgr, up, chunk, idx);
>         if (unlikely(ret) && drm_debug_enabled(DRM_UT_DP)) {
> -               struct drm_printer p = drm_debug_printer(DBG_PREFIX);
> +               struct drm_printer p = drm_debug_category_printer(DRM_UT_DP,
> +                                                                
> DBG_PREFIX);
>  
>                 drm_printf(&p, "sideband msg failed to send\n");
>                 drm_dp_mst_dump_sideband_msg_tx(&p, txmsg);
> @@ -2917,7 +2919,8 @@ static void drm_dp_queue_down_tx(struct
> drm_dp_mst_topology_mgr *mgr,
>         list_add_tail(&txmsg->next, &mgr->tx_msg_downq);
>  
>         if (drm_debug_enabled(DRM_UT_DP)) {
> -               struct drm_printer p = drm_debug_printer(DBG_PREFIX);
> +               struct drm_printer p = drm_debug_category_printer(DRM_UT_DP,
> +                                                                
> DBG_PREFIX);
>  
>                 drm_dp_mst_dump_sideband_msg_tx(&p, txmsg);
>         }

-- 
Cheers,
 Lyude Paul (she/her)
 Software Engineer at Red Hat




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux