Hello Geert, On 7/27/21 1:39 PM, Geert Uytterhoeven wrote: [snip] >>> Perhaps SYSFB should be selected by SYSFB_SIMPLEFB, FB_VESA, >>> and FB_EFI? >> >> It's another option, yes. I just thought that the use of select was not >> encouraged and using depends was less fragile / error prone. > > Select is very useful for config symbols that are invisible to the user (i.e. > cannot be enabled/disabled manually). > Got it. I don't have a strong opinion on this really. In fact, the first version of the patch did use select for the arches but I got as feedback that should use depends instead: https://www.mail-archive.com/dri-devel@xxxxxxxxxxxxxxxxxxxxx/msg351961.html Granted, that was for the arches but you are proposing to do it for the drivers that match against the platform devices registered by sysfb. So it does make more sense to what I did in v1. Best regards, -- Javier Martinez Canillas Linux Engineering Red Hat
