Quoting Bjorn Andersson (2021-07-24 21:24:36) > The sc8180x has 2 DP and 1 eDP controllers, add support for these to the > DP driver. > > Link: https://lore.kernel.org/linux-arm-msm/20210511042043.592802-5-bjorn.andersson@xxxxxxxxxx/ > Signed-off-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx> > --- > drivers/gpu/drm/msm/dp/dp_display.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c > index 92b7646a1bb7..c26805cfcdd1 100644 > --- a/drivers/gpu/drm/msm/dp/dp_display.c > +++ b/drivers/gpu/drm/msm/dp/dp_display.c > @@ -129,8 +129,20 @@ static const struct msm_dp_config sc7180_dp_cfg = { > .num_dp = 1, > }; > > +static const struct msm_dp_config sc8180x_dp_cfg = { > + .io_start = { 0xae90000, 0xae98000, 0 }, > + .num_dp = 3, > +}; > + > +static const struct msm_dp_config sc8180x_edp_cfg = { > + .io_start = { 0, 0, 0xae9a000 }, > + .num_dp = 3, > +}; Can the two structs not be combined into one struct and set as .data for either compatible? > + > static const struct of_device_id dp_dt_match[] = { > { .compatible = "qcom,sc7180-dp", .data = &sc7180_dp_cfg }, > + { .compatible = "qcom,sc8180x-dp", .data = &sc8180x_dp_cfg }, > + { .compatible = "qcom,sc8180x-edp", .data = &sc8180x_edp_cfg }, > {}
