On 7/26/21 10:34 AM, Linus Walleij wrote: > Hi Iskren, > > thanks for your patch! Thanks a lot for reviewing this. Alexey wrote a new version of the patch [1] that was recently reviewed by Sam, and it also includes support for brightness and another panel found on the S5. My patch is pretty much untouched out of the panel driver generator, so we can definitely improve the generated code based on your comments. [1] https://lists.freedesktop.org/archives/dri-devel/2021-July/316804.html I guess Alexey will submit a new version with the two panels split, and he might incorporate your suggestions (as his code comes from the generator as well). Regards, Iskren