Hi > Gesendet: Montag, 26. Juli 2021 um 02:27 Uhr > Von: "Chun-Kuang Hu" <chunkuang.hu@xxxxxxxxxx> > As I've discussed in [1], SOUT has many bits and need to be cleared > before set new value. Of course, write only could do the clear, but > for MOUT, it clear the bits that should not be cleared. If you want to > use the table, you need to implement the 'mask'. > > [1] https://patchwork.kernel.org/project/linux-mediatek/patch/trinity-937ebfa3-d123-42de-a289-3ad0dbc09782-1625830110576@3c-app-gmx-bap43/ I've added the mask like you did here [1] on my repo [2] and it works too...should i use you as author as i only take your code when posting? regards Frank [1] https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/2345186/5/drivers/soc/mediatek/mtk-mmsys.c#294 [2] https://github.com/frank-w/BPI-R2-4.14/commits/5.14-mmsys