Re: [PATCH -next] drm/exynos: g2d: fix missing unlock on error in g2d_runqueue_worker()

[Inki Dae <daeinki@xxxxxxxxx>]

Sorry for late and thanks for fixing it.

Thanks,

Inki Dae

2021년 6월 16일 수요일, Wei Yongjun <weiyongjun1@xxxxxxxxxx>님이 작성:

Add the missing unlock before return from function g2d_runqueue_worker()
in the error handling case.

Fixes: 445d3bed75de ("drm/exynos: use pm_runtime_resume_and_get()")
Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
Signed-off-by: Wei Yongjun <weiyongjun1@xxxxxxxxxx>
---
 drivers/gpu/drm/exynos/exynos_drm_g2d.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.c b/drivers/gpu/drm/exynos/exynos_drm_g2d.c
index cab4d2c370a7..0ed665501ac4 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_g2d.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_g2d.c
@@ -897,13 +897,14 @@ static void g2d_runqueue_worker(struct work_struct *work)
                        ret = pm_runtime_resume_and_get(g2d->dev);
                        if (ret < 0) {
                                dev_err(g2d->dev, "failed to enable G2D device.\n");
-                               return;
+                               goto out;
                        }

                        g2d_dma_start(g2d, g2d->runqueue_node);
                }
        }

+out:
        mutex_unlock(&g2d->runqueue_mutex);
 }