On Sat 17 Jul 07:40 CDT 2021, Dmitry Baryshkov wrote:
> None of the display drivers now implement set_encoder_mode callback.
> Stop calling it from the modeset init code.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> Reviewed-by: Abhinav Kumar <abhinavk@xxxxxxxxxxxxxx>
Reviewed-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
Regards,
Bjorn
> ---
> drivers/gpu/drm/msm/dp/dp_display.c | 18 ------------------
> 1 file changed, 18 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c
> index 051c1be1de7e..70b319a8fe83 100644
> --- a/drivers/gpu/drm/msm/dp/dp_display.c
> +++ b/drivers/gpu/drm/msm/dp/dp_display.c
> @@ -102,8 +102,6 @@ struct dp_display_private {
> struct dp_display_mode dp_mode;
> struct msm_dp dp_display;
>
> - bool encoder_mode_set;
> -
> /* wait for audio signaling */
> struct completion audio_comp;
>
> @@ -283,20 +281,6 @@ static void dp_display_send_hpd_event(struct msm_dp *dp_display)
> }
>
>
> -static void dp_display_set_encoder_mode(struct dp_display_private *dp)
> -{
> - struct msm_drm_private *priv = dp->dp_display.drm_dev->dev_private;
> - struct msm_kms *kms = priv->kms;
> -
> - if (!dp->encoder_mode_set && dp->dp_display.encoder &&
> - kms->funcs->set_encoder_mode) {
> - kms->funcs->set_encoder_mode(kms,
> - dp->dp_display.encoder, false);
> -
> - dp->encoder_mode_set = true;
> - }
> -}
> -
> static int dp_display_send_hpd_notification(struct dp_display_private *dp,
> bool hpd)
> {
> @@ -369,8 +353,6 @@ static void dp_display_host_init(struct dp_display_private *dp, int reset)
> if (dp->usbpd->orientation == ORIENTATION_CC2)
> flip = true;
>
> - dp_display_set_encoder_mode(dp);
> -
> dp_power_init(dp->power, flip);
> dp_ctrl_host_init(dp->ctrl, flip, reset);
> dp_aux_init(dp->aux);
> --
> 2.30.2
>
