On Sat, Jul 24, 2021 at 8:55 AM Arnd Bergmann <arnd@xxxxxxxxxx> wrote: > > On Sat, Jul 24, 2021 at 12:47 AM Karol Herbst <kherbst@xxxxxxxxxx> wrote: > > > > In the past this only led to compilation issues. Also the small amount of > > extra .text shouldn't really matter compared to the entire nouveau driver > > anyway. > > > > > select DRM_TTM_HELPER > > - select BACKLIGHT_CLASS_DEVICE if DRM_NOUVEAU_BACKLIGHT > > - select ACPI_VIDEO if ACPI && X86 && BACKLIGHT_CLASS_DEVICE && INPUT > > + select BACKLIGHT_CLASS_DEVICE > > + select ACPI_VIDEO if ACPI && X86 && INPUT > > select X86_PLATFORM_DEVICES if ACPI && X86 > > select ACPI_WMI if ACPI && X86 > > I think the logic needs to be the reverse: instead of 'select > BACKLIGHT_CLASS_DEVICE', > this should be 'depends on BACKLIGHT_CLASS_DEVICE', and the same for ACPI_VIDEO. > > We may want to add 'default DRM || FB' to BACKLIGHT_CLASS_DEVICE in the > process so we don't lose it for users doing 'make oldconfig' or 'make defconfig' > yeah.. not sure. I tested it locally (config without backlight enabled) and olddefconfig just worked. I think the problem with "depends" is that the user needs to enable backlight support first before even seeing nouveau and I don't know if that makes sense. But maybe "default" is indeed helping here in this case. > The rest of the patch looks good to me. > > Arnd >
