Re: [PATCH 1/2] dt-bindings: display: panel: Add ilitek ili9341 panel bindings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Linus,

Thanks for your detailed reply.

On Sun, 18 Jul 2021 at 08:17, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
Hi Dillon,

thanks for your patch!

On Fri, Jul 16, 2021 at 12:20 PM <dillon.minfei@xxxxxxxxx> wrote:

> From: Dillon Min <dillon.minfei@xxxxxxxxx>
>
> Add documentation for "ilitek,ili9341" panel.
>
> Signed-off-by: Dillon Min <dillon.minfei@xxxxxxxxx>

> +  dc-gpios:
> +    maxItems: 1
> +    description: Display data/command selection (D/CX)

This is a DBI feature so mention in the description that this is a
DBI panel.

Okay, I will add the DBI panel to v2.
 

> +  spi-3wire: true
> +
> +  spi-max-frequency:
> +    const: 10000000
> +
> +  port: true
> +
> +additionalProperties: false

Please add regulator supplies for the power lines, it's fine
not to implement code handling them in the driver but they
should be in the bindings.

For the ili9341 it should be

  vci-supply:
    description: Analog voltage supply (2.5 .. 3.3V)

  vddi-supply:
    description: Voltage supply for interface logic (1.65 .. 3.3 V)

  vddi-led-supply:
    description: Voltage supply for the LED driver (1.65 .. 3.3 V)


Thanks so much, I will add it to v2.
 
Yours,
Linus Walleij

[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux