Hi Maxime,
On Tue, Jul 20, 2021 at 03:45:23PM +0200, Maxime Ripard wrote:
> The mipi_dsi_device allocated by mipi_dsi_device_register_full() is
> already free'd on release.
>
> Fixes: 2f733d6194bd ("drm/panel: Add support for the Raspberry Pi 7" Touchscreen.")
> Signed-off-by: Maxime Ripard <maxime@xxxxxxxxxx>
Reviewed-by: Sam Ravnborg <sam@xxxxxxxxxxxx>
I did a quick audit (as using grep mostly) to see if other panels had
the same bug, but did not find others.
This patch should be applied to drm-misc-fixes independent of the rest of
the patches.
Sam
> ---
> drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c b/drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c
> index 6f2ce3b81f47..462faae0f446 100644
> --- a/drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c
> +++ b/drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c
> @@ -447,7 +447,6 @@ static int rpi_touchscreen_remove(struct i2c_client *i2c)
> drm_panel_remove(&ts->base);
>
> mipi_dsi_device_unregister(ts->dsi);
> - kfree(ts->dsi);
>
> return 0;
> }
> --
> 2.31.1
