On Fri, 16 Jul 2021 at 20:21, Matthew Auld <matthew.william.auld@xxxxxxxxx> wrote: > > On Fri, 16 Jul 2021 at 15:14, Jason Ekstrand <jason@xxxxxxxxxxxxxx> wrote: > > > > Instead of hand-rolling the same three calls in each function, pull them > > into an i915_gem_object_create_user helper. Apart from re-ordering of > > the placements array ENOMEM check, there should be no functional change. > > > > v2 (Matthew Auld): > > - Add the call to i915_gem_flush_free_objects() from > > i915_gem_dumb_create() in a separate patch > > - Move i915_gem_object_alloc() below the simple error checks > > > > Signed-off-by: Jason Ekstrand <jason@xxxxxxxxxxxxxx> > > Cc: Matthew Auld <matthew.auld@xxxxxxxxx> > > If CI is happy, > Reviewed-by: Matthew Auld <matthew.auld@xxxxxxxxx> Might be good to also update the mman selftests to use this new helper.
