Hi,
On Thu, Jul 15, 2021 at 1:02 AM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
>
> Panels with internal backlight need to assign their backlight member
> directly.
>
> Reported-by: Doug Anderson <dianders@xxxxxxxxxxxx>
> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> ---
> include/drm/drm_panel.h | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/include/drm/drm_panel.h b/include/drm/drm_panel.h
> index 33605c3f0eba..1e63fadf1368 100644
> --- a/include/drm/drm_panel.h
> +++ b/include/drm/drm_panel.h
> @@ -144,8 +144,9 @@ struct drm_panel {
> * Backlight device, used to turn on backlight after the call
> * to enable(), and to turn off backlight before the call to
> * disable().
> - * backlight is set by drm_panel_of_backlight() and drivers
> - * shall not assign it.
> + * External backlight is assigned by drm_panel_of_backlight() while
> + * panel-internal backlight is assigned directly to this member by the
> + * panel driver.
Can you rebase/post against drm-misc-next? If not then you'll conflict
with commit 10f7b40e4f30 ("drm/panel: add basic DP AUX backlight
support"). :-)
-Doug
