Re: [PATCH -next v2] drm/bochs: Fix missing pci_disable_device() on error in bochs_pci_probe()

[Thomas Zimmermann <tzimmermann@xxxxxxx>]

Hi

Am 15.07.21 um 13:03 schrieb Yang Yingliang:
> On 2021/7/15 17:30, Thomas Zimmermann wrote:
> > Hi,
> >
> > for the change
> >
> >
> > Acked-by: Thomas Zimmermann <tzimmermann@xxxxxxx>
> >
> >
> > but there are some style issues AFAICS.
> OK, need I resend it with the style changes and your ack ?

Please do. I'll merge it a few days later if no further comments come in.

Best regards
Thomas

> > Am 15.07.21 um 04:05 schrieb Yang Yingliang:
> > > Replace pci_enable_device() with pcim_enable_device(),
> > > pci_disable_device() will be called in release automatically.
> > >
> > > Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> > > Signed-off-by: Yang Yingliang <yangyingliang@xxxxxxxxxx>
> >
> > S-o-b line goes first
> >
> > > ---
> > > v2:
> > >    use pcim_enable_device()
> >
> > This changelog should rather be located between the commit description 
> > and the first S-o-b line.
> >
> > Best regards
> > Thomas
> >
> > > ---
> > >   drivers/gpu/drm/tiny/bochs.c | 2 +-
> > >   1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/gpu/drm/tiny/bochs.c b/drivers/gpu/drm/tiny/bochs.c
> > > index a2cfecfa8556..73415fa9ae0f 100644
> > > --- a/drivers/gpu/drm/tiny/bochs.c
> > > +++ b/drivers/gpu/drm/tiny/bochs.c
> > > @@ -648,7 +648,7 @@ static int bochs_pci_probe(struct pci_dev *pdev, 
> > > const struct pci_device_id *ent
> > >       if (IS_ERR(dev))
> > >           return PTR_ERR(dev);
> > >   -    ret = pci_enable_device(pdev);
> > > +    ret = pcim_enable_device(pdev);
> > >       if (ret)
> > >           goto err_free_dev;

--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer

Attachment: OpenPGP_signature
Description: OpenPGP digital signature