Hi, On Wed, Jul 14, 2021 at 3:52 PM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote: > > This adds a driver for panels based on the WideChips WS2401 display > controller. This display controller is used in the Samsung LMS380KF01 > display found in the Samsung GT-I8160 (Codina) mobile phone and > possibly others. > > As is common with Samsung displays manufacturer commands are necessary > to configure the display to a working state. > > The display optionally supports internal backlight control, but can > also use an external backlight. > > This driver re-uses the DBI infrastructure to communicate with the > display. > > Cc: phone-devel@xxxxxxxxxxxxxxx > Cc: Douglas Anderson <dianders@xxxxxxxxxxxx> > Reviewed-by: Noralf Trønnes <noralf@xxxxxxxxxxx> > Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx> > Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx> > --- > ChangeLog v3->v4: > - Add more talkative Kconfig telling which mobile phone has this. > - Make sure to turn off the internal backlight totally if requested. > - Alter the logic so that we assign the backlight handle to > panel->backlight directly and save some code. Officially this is disallowed according to comments. ...and I quote: /** * @backlight: * * Backlight device, used to turn on backlight after the call * to enable(), and to turn off backlight before the call to * disable(). * backlight is set by drm_panel_of_backlight() or * drm_panel_dp_aux_backlight() and drivers shall not assign it. */ I do not personally know the motivation of not letting drivers assign it, but with the words "shall not". Yikes! -Doug
