On Wed, Jul 07, 2021 at 01:50:21PM +0200, Christian König wrote:
Am 07.07.21 um 12:52 schrieb Lucas Stach:
Am Dienstag, dem 06.07.2021 um 07:11 -0400 schrieb Sasha Levin:
From: Tian Tao <tiantao6@xxxxxxxxxxxxx>
[ Upstream commit 7d614ab2f20503ed8766363d41f8607337571adf ]
fixed the below warning:
drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c:84:2-8: WARNING: NULL check
before some freeing functions is not needed.
While the subject contains "fix" this only removes a duplicated NULL
check, so the code is correct before and after this change.
Is this really stable material? Doesn't this just add commit noise to
the stable kernels?
Yeah, agree.
I also had a case where a NULL check was removed in amdgpu and then a
bit later back ported to stable.
Maybe just use something like "remove superfluous NULL check".
Sorry for missing that, I'll drop it. Thanks!
--
Thanks,
Sasha
