Re: [PATCH 29/47] drm/i915/guc: Disable bonding extension with GuC submission

[John Harrison <john.c.harrison@xxxxxxxxx>]

On 6/24/2021 00:04, Matthew Brost wrote:
> Update the bonding extension to return -ENODEV when using GuC submission
> as this extension fundamentally will not work with the GuC submission
> interface.
>
> Signed-off-by: Matthew Brost <matthew.brost@xxxxxxxxx>
Reviewed-by: John Harrison <John.C.Harrison@xxxxxxxxx>

> ---
>   drivers/gpu/drm/i915/gem/i915_gem_context.c | 5 +++++
>   1 file changed, 5 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context.c b/drivers/gpu/drm/i915/gem/i915_gem_context.c
> index 8a9293e0ca92..0429aa4172bf 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_context.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_context.c
> @@ -1674,6 +1674,11 @@ set_engines__bond(struct i915_user_extension __user *base, void *data)
>   	}
>   	virtual = set->engines->engines[idx]->engine;
>   
> +	if (intel_engine_uses_guc(virtual)) {
> +		DRM_DEBUG("bonding extension not supported with GuC submission");
> +		return -ENODEV;
> +	}
> +
>   	err = check_user_mbz(&ext->flags);
>   	if (err)
>   		return err;