On 7/9/21 11:23 AM, Simon Ser wrote: > On Friday, July 9th, 2021 at 11:09, Raphael Gallais-Pou <raphael.gallais-pou@xxxxxxxxxxx> wrote: > >> We don't usually test with piglit and igt-gpu-tools. Instead, modetest >> utility of the libdrm is used quite often (as is it the case in order to >> test this property). > Just to make it extra clear: regardless of how you bring up your driver > implementation, without an IGT test and real-world open-source user-space > patches that make use of the new prop, your patches *cannot* be merged. > > If you're planning to add support for the new prop to an open-source KMS > client, please add a link to the patches in your kernel submission. If > you don't have plans to use the new prop in an open-source KMS client, > let us know and we can discuss what the best candidate would be. Hi, Thanks for your feedback :) We do not have any KMS client currently using this property apart from proprietary solutions made by consumers. This property was originally made to display a logo picture when the screen is in idle (low power/low DDR usage). Regards, Raphaël >> I was also thinking about implementing an option into modetest to ease >> the use of this drm property (support of hexadecimal values for properties). > (For the record, modeset doesn't count as a real-world user-space usage: it's > just a toy implementation, just a test tool.) > > Simon